-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: swipe to reply not working on first try #3061
fix: swipe to reply not working on first try #3061
Conversation
Test Results928 tests 928 ✅ 12m 37s ⏱️ Results for commit ed19460. ♻️ This comment has been updated with latest results. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 5109 succeeded. The build produced the following APK's: |
Quality Gate passedIssues Measures |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 5114 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
As noticed by some, the
swipeToReply
doesn't work properly on first time.Causes
1.6.x
stable version of Compose Foundation.1.7.0-alpha
version.1.7.0-beta
version.But, it seems that it has a breaking change now that I'm not sure if is intended or not, so I opened an issue on Google's Issue Tracker.
We override the local touchSlop to make easier to scroll through the messages without activating the swipe action.
But with these new versions of Foundation, when overriding the the
touchSlop
locally using aCompositionLocalProvider
, we need to make sure that both theAnchoredDraggableState
and theanchoredDraggable
modifier are used within the same local composition provider.Solutions
Just move the
AnchoredDraggableState
initialisation inside theCompositionLocalProvider
.ALSO, a slight improvement: reduce a bit the drag required to reply. When developing it I was a bit unsure if 25% or 33% of the screen was best initially, but 33% is a bit too much compared to the experience in other messengers.
Testing
Manually tested
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.